search

Prezent / doctrine-translatable

Translatable behaviour extension for Doctrine2
MIT License
26 stars 17 forks source link

Upgrade to jms/metadata v2 #33

Closed NielsJanssen closed 5 years ago

NielsJanssen commented 5 years ago

This PR adds support for jms/metadata v2, this keeps full backwards compatibility with the v1 version as well.

BC break

The the minimum PHP version has to be raised to 7.1.0, because of the addition of nullable return types. Hopefully this isn't too big of an issue, since PHP 7.0 and below have already EoL'd. Though it would probably require a major version bump.

NielsJanssen commented 5 years ago

I tried to fix the tests, but I can't seem to get the test for PHP 7.1 working. Making Travis use PHPUnit 7 and reverting my PHPUnit 8 fixes might work, but I don't know how to convince Travis to use a different PHPUnit version.

sandermarechal commented 5 years ago

This looks pretty cool! I'll have a look at the tests myself.

sandermarechal commented 5 years ago

Merged, and I fixed the unit tests (well... dropped a bunch of outdated versions). I'll tag a new release shortly. Thanks for your contribution!