search

Prezent / doctrine-translatable

Translatable behaviour extension for Doctrine2
MIT License
26 stars 17 forks source link

Improve XML mapping #39

Closed mdeboer closed 3 years ago

mdeboer commented 3 years ago

Provides a proper XML schema to provide autocomplete and validation on mapping files. I have also cleaned up the code and use separate elements for translatable and translation as they both feature different attributes and requirements.

It is recommended to host the XSD schema somewhere, possibly at https://prezent.nl/schemas/doctrine-translatable-3.0.xsd. I added the 3.0 version suffix as I think this would go as a BC break regarding XML mapping.

I based this PR off the current master, not off my other PR. Either one can be merged first.

Please let me know what you think 👍

sandermarechal commented 3 years ago

Looks good! Before I merge it I will look into hosting the XSD though.

mdeboer commented 3 years ago

Hey @sandermarechal any luck hosting the XSD file or can I do anything to help? There's no specific requirements, just a plain file to host in a directory :) Let me know if you need anything, I would really like to use this!

sandermarechal commented 3 years ago

It's not quite so simple on our end as uploading a file. I'll need to have a chat with our sysadmin after the holidays. I assume this change is also usable without a hosted file, so I will merge it and tag a new release.

sandermarechal commented 3 years ago

Merged and tagged as 3.0.0. Thank you!