search

Prezent / prezent-grid-bundle

Integrate prezent-grid in Symfony
MIT License
6 stars 3 forks source link

Add 'sort_order' variable to the sortable header view #8

Closed seydu closed 6 years ago

seydu commented 6 years ago

Add sort_order variable to the sortable header view and use it to set data-sort-dir HTML attribute. Setting data-sort-dir to asc or desc will be consistent with the CSS definitions.

seydu commented 6 years ago

There was not tests for the template, so I did not add a failing one before making the changes. I really like the design of the underlying package, very well inspired by the form component. I will work on setting up tests for the templates

sandermarechal commented 6 years ago

Thanks!