search

PriceLab / probannopy

A python package for Probanno!
9 stars 3 forks source link

Python 3 #4

Closed sulheim closed 4 years ago

sulheim commented 4 years ago

Solves issue #2 Tested the functions for getting fasta files, generating reaction probabilities and generating template model.

Tested with python 3.7.

I have note changed the requirements.txt file.

kingb12 commented 4 years ago

Awesome! Thanks for the PR, this is great, sorry it took so long for me to look into it. Found a couple changes I needed to make to get it to work on a fresh python3 virtualenv, I'll summarize here in case you have any thoughts or see issues later, but I'll just commit on top of yours after merging.

requirements.txt -> drop the logging import __init__.py -> the probanno/ gets treated as a module now, itself containing a probanno module (the probanno.py file). To not have to do from probanno import probanno, modifying the exports defined here.