PrideChung / FontAwesomeKit

Icon font library for iOS. Currently supports Font-Awesome, Foundation icons, Zocial, and ionicons.
MIT License
2.81k stars 308 forks source link

Fix IconMapViewController in example project #103

Open GabLeRoux opened 7 years ago

GabLeRoux commented 7 years ago

I gave example project a try and it works well, but there's a problem with the last page which exposes all icons:

image

None icons are being displayed from that last tab, tried all icon sets.

Clicking an icons logs this:

===================Code Autogeneration ===================

FAKFontAwesome *Icon = [FAKFontAwesome IconWithSize:30];
[Icon addAttribute:NSForegroundColorAttributeName value:[UIColor whiteColor]];
UIImage *IconImage = [Icon imageWithSize:CGSizeMake(30, 30)];

==========================================================

I'd say this code generator is broken, it shouldn't be using the computed characters, but the character's name instead.

Problem would be somewhere in FontAwesomeKitExample/FontAwesomeKitExample/IconMapViewController.m

I suppose this used to work in previous versions of xcode. It's not a big problem, but I'm sure this would deserve a fix as it may prevent new people from using this library as it seems broken, but everything else works fine.

I see that a swift rewrite was planed for the code generator in #92