Added a lookup method that uses an identifier to create an icon

PrideChung / FontAwesomeKit

Icon font library for iOS. Currently supports Font-Awesome, Foundation icons, Zocial, and ionicons.

MIT License

2.81k stars 308 forks source link

Added a lookup method that uses an identifier to create an icon #64

Closed GabrielCartier closed 8 years ago

GabrielCartier commented 8 years ago

Issue was discussed in #53, the idea is to be able to create icons using the string identifiers associated with the icons. I added an error to fit the Swift structure. The error is set when identifier is not found in allIcons.

I updated the generator scripts to automatically be able to generate the methods.

GabrielCartier commented 8 years ago

The readme file might need some modification based on PR #65

top2tech commented 8 years ago

looks like there are conflicts with master?

GabrielCartier commented 8 years ago

What are the conflicts? How can I help?

MontakOleg commented 8 years ago

Gabriel, thanks for you work.

Below comments, there is 'branch has conflicts' badge

You should make pull from PrideChung:master, resolve conflicts and push to GabrielCartier:master. Then, PR can be merged.

GabrielCartier commented 8 years ago

Just pushed an update. I did the merge request with the latest version, everything is now merge-able.

Let me know if there is anything.