search

PrideChung / FontAwesomeKit

Icon font library for iOS. Currently supports Font-Awesome, Foundation icons, Zocial, and ionicons.
MIT License
2.81k stars 308 forks source link

Update Font Awesome 4.5 to Font Awesome 4.6 and add Carthage support #88

Closed ecdfeaa2 closed 8 years ago

ecdfeaa2 commented 8 years ago

This pull request update Font Awesome to 4.6 version and add a Carthage support

hy9be commented 8 years ago

@PrideChung could you review this PR and see if you want to merge it? Thanks!

hy9be commented 8 years ago

@RemyDCF I run into errors

xcodebuild: error: Unable to find a destination matching the provided destination specifier:
        { platform:iOS Simulator, id:478AE865-1112-4DD6-AAB7-EE718E90D7A6 }
hy9be commented 8 years ago

Not quite sure but I suspect the problem is that you specified the deployment target to 10.0 in your xcodeproj file: https://github.com/PrideChung/FontAwesomeKit/pull/88/commits/3c2dc80791b778b68004a9a8330dc40ad78425b9#diff-4d794de573ae23cd89ba70c61fc73dd6R262 https://github.com/PrideChung/FontAwesomeKit/pull/88/commits/3c2dc80791b778b68004a9a8330dc40ad78425b9#diff-4d794de573ae23cd89ba70c61fc73dd6R307

If you do not have to, I suggest do not set the deployment target to 10.0. @RemyDCF Do you want to take a look?

ecdfeaa2 commented 8 years ago

I created a new pull request ( #95 ). Does it work now ?

hy9be commented 8 years ago

@RemyDCF It works now on your fork.