PrimalHQ / primal-android-app

Primal's Android app for Nostr.
https://primal.net/downloads
MIT License
110 stars 13 forks source link

In bookmarks window, if I remove a note from bookmarks, the note should instantly disappear of bookmarks window #137

Open bitcoinuser opened 2 months ago

bitcoinuser commented 2 months ago

Hi,

In bookmarks window, if I remove a note from bookmarks, the note should instantly disappear of bookmarks window. For now if I remove a note, the note still stay until I go back to feed window and open bookmarks window again. Obs. When we remove or add a note to bookmark, there are no indications that the note was really added or removed to bookmark. We need to go to bookmarks window to be sure it worked.

Thanks.

AleksandarIlic commented 1 month ago

In bookmarks window, if I remove a note from bookmarks, the note should instantly disappear of bookmarks window. For now if I remove a note, the note still stay until I go back to feed window and open bookmarks window again.

It's not a bug, it's a feature. Seriously.

Obs. When we remove or add a note to bookmark, there are no indications that the note was really added or removed to bookmark. We need to go to bookmarks window to be sure it worked.

You could also open dropdown menu again in few seconds. The state will reflect there as well immediately after network calls. We initially assume success, but if operation fails, we revert to previous state.

I agree that some toast message would be helpful.

bitcoinuser commented 1 month ago

I agree that some toast message would be helpful

Yes