search

Prime-Access-Consulting / nvda-at-automation

Implementation of the AT Automation Driver specification for the NVDA screen reader
GNU General Public License v2.0
3 stars 3 forks source link

up and down presskey events don't seem to be working #46

Closed gnarf closed 11 months ago

gnarf commented 1 year ago

I've consistently been noticing the up/down key based tests not returning any output in the automation suite, and am unsure if it affects other keys yet (will report if I find others). The command is correctly sending \ue015 or \ue013, but the key does not seem to be being pressed. I have confirmed that if I press the key myself on the keyboard when the driver is being asked to press it the tests do run correctly, so am fairly certain this is just not pressing the key in the NVDA at-driver.

Many others of the unicode space ones: (tab/shift) seem to work correctly so thinking it is just the arrows.

gnarf commented 1 year ago

Here is some output from grep -C5 "invalid gesture" nvda.log after running some of the test suites (so far of the tests I've tested only those with up & down commands seem to trigger the error)


ERROR - stderr (14:04:08.128) - Thread-3 (10200):
127.0.0.1 - - [15/Nov/2023 14:04:08] "POST /presskeys HTTP/1.1" 200 -
WARNING - stdout (14:04:53.070) - Thread-3 (10200):
executing gesture "down"
WARNING - stdout (14:04:53.070) - Thread-3 (10200):
invalid gesture "down
ERROR - stderr (14:04:53.070) - Thread-3 (10200):
127.0.0.1 - - [15/Nov/2023 14:04:53] "POST /presskeys HTTP/1.1" 200 -
ERROR - queueHandler.flushQueue (14:05:01.287) - MainThread (9348):
Error in func _TextReader.nextLine
Traceback (most recent call last):
--
ERROR - stderr (14:10:00.612) - Thread-3 (10200):
127.0.0.1 - - [15/Nov/2023 14:10:00] "POST /presskeys HTTP/1.1" 200 -
WARNING - stdout (14:10:45.682) - Thread-3 (10200):
executing gesture "down"
WARNING - stdout (14:10:45.682) - Thread-3 (10200):
invalid gesture "down
ERROR - stderr (14:10:45.682) - Thread-3 (10200):
127.0.0.1 - - [15/Nov/2023 14:10:45] "POST /presskeys HTTP/1.1" 200 -
WARNING - stdout (14:11:25.783) - Thread-3 (10200):
executing gesture "shift+b"
ERROR - stderr (14:11:25.785) - Thread-3 (10200):
--
ERROR - stderr (14:12:55.829) - Thread-3 (10200):
127.0.0.1 - - [15/Nov/2023 14:12:55] "POST /presskeys HTTP/1.1" 200 -
WARNING - stdout (14:13:40.811) - Thread-3 (10200):
executing gesture "up"
WARNING - stdout (14:13:40.811) - Thread-3 (10200):
invalid gesture "up
ERROR - stderr (14:13:40.811) - Thread-3 (10200):
127.0.0.1 - - [15/Nov/2023 14:13:40] "POST /presskeys HTTP/1.1" 200 -
ERROR - queueHandler.flushQueue (14:13:58.941) - MainThread (9348):
Error in func _TextReader.nextLine
Traceback (most recent call last):
--
ERROR - stderr (14:16:01.047) - Thread-3 (10200):
127.0.0.1 - - [15/Nov/2023 14:16:01] "POST /presskeys HTTP/1.1" 200 -
WARNING - stdout (14:16:46.066) - Thread-3 (10200):
executing gesture "insert+up"
WARNING - stdout (14:16:46.066) - Thread-3 (10200):
invalid gesture "insert+up
ERROR - stderr (14:16:46.066) - Thread-3 (10200):
127.0.0.1 - - [15/Nov/2023 14:16:46] "POST /presskeys HTTP/1.1" 200 -
ERROR - queueHandler.flushQueue (14:16:53.961) - MainThread (9348):
Error in func _TextReader.nextLine
Traceback (most recent call last):
--
ERROR - stderr (08:57:01.104) - Thread-3 (10200):
127.0.0.1 - - [16/Nov/2023 08:57:01] "POST /presskeys HTTP/1.1" 200 -
WARNING - stdout (08:57:46.357) - Thread-3 (10200):
executing gesture "down"
WARNING - stdout (08:57:46.358) - Thread-3 (10200):
invalid gesture "down
ERROR - stderr (08:57:46.358) - Thread-3 (10200):
127.0.0.1 - - [16/Nov/2023 08:57:46] "POST /presskeys HTTP/1.1" 200 -
ERROR - queueHandler.flushQueue (08:57:59.621) - MainThread (9348):
Error in func _TextReader.nextLine
Traceback (most recent call last):
--
ERROR - stderr (09:00:01.100) - Thread-3 (10200):
127.0.0.1 - - [16/Nov/2023 09:00:01] "POST /presskeys HTTP/1.1" 200 -
WARNING - stdout (09:00:46.293) - Thread-3 (10200):
executing gesture "up"
WARNING - stdout (09:00:46.293) - Thread-3 (10200):
invalid gesture "up
ERROR - stderr (09:00:46.293) - Thread-3 (10200):
127.0.0.1 - - [16/Nov/2023 09:00:46] "POST /presskeys HTTP/1.1" 200 -
ERROR - queueHandler.flushQueue (09:00:54.543) - MainThread (9348):
Error in func _TextReader.nextLine
Traceback (most recent call last):
gnarf commented 11 months ago

I think I've managed to find a solution that will fix this issue - expect a PR shortly (running it through some tests, etc)