search

Prime-Holding / rx_bloc

A set of Flutter packages that help implement the BloC (Business Logic Component) design pattern using the power of reactive streams
https://pub.dev/packages/rx_bloc
62 stars 21 forks source link

Fix pipeline issues #684

Closed DDavidPrime closed 1 month ago

DDavidPrime commented 1 month ago

Addresses pipeline issues regarding deprecated theme parameters.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.45%. Comparing base (e3289e4) to head (eb8fa89). Report is 20 commits behind head on develop.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #684 +/- ## =========================================== + Coverage 85.58% 93.45% +7.87% =========================================== Files 98 14 -84 Lines 2143 275 -1868 =========================================== - Hits 1834 257 -1577 + Misses 309 18 -291 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DDavidPrime commented 1 month ago

Since the only remaining job is the one failing due to some goldens, this will be handled in a separate PR. We need the to update the goldens, but in order to do so, we need to re-generate them. I've added a workflow which generates goldens, but this option will be available only after it is merged to the default branch (source https://stackoverflow.com/a/71423764).