search

Prime-Holding / rx_bloc

A set of Flutter packages that help implement the BloC (Business Logic Component) design pattern using the power of reactive streams
https://pub.dev/packages/rx_bloc
62 stars 21 forks source link

Update codemagic workflow inputs and documentation #707

Closed DDavidPrime closed 3 months ago

DDavidPrime commented 3 months ago

Overview

Closes: #706

Addresses leftover comments from testing of the Codemagic functionality

Checklist

Implementation

Stability ~- [ ] Checked if changes affect any features and verified affected features work as expected~ ~- [ ] Added unit tests for new code and verified existing tests work as expected~

Code quality ~- [ ] Updated CHANGELOG.md, README.md and package versions in pubspec.yaml~ ~- [ ] Dependencies are updated to latest versions or new tickets are created if there are breaking changes or deprecations~ ~- [ ] If an unrelated part of the codebase needs to be updated or refactored, create tickets with proposed changes~

DDavidPrime commented 3 months ago

@StanevPrime After a discussion with @GoranPrime , he will be testing the codemagic implementation. After this is done and everything goes accordingly, I will merge the PR.

GoranPrime commented 3 months ago

I've tested the whole flow locally, and everything works as expected!

The only small comment I have is that perhaps we could add an optional flag to crypt.sh which deletes the originals after encrypting and checking them. This should absolutely not be a blocker for the release, just something that popped up while going through it, as maybe being useful to someone.

GoranPrime commented 3 months ago

Also the documentation should be updated here with the latest strings: https://github.com/Prime-Holding/rx_bloc/blob/aedfde0ea86e1dbdb84acb15984ec8251301b038/packages/rx_bloc_cli/mason_templates/bricks/feature_cicd_fastlane/__brick__/docs/continuous_delivery.md?plain=1#L137