Prime-Holding / rx_bloc

A set of Flutter packages that help implement the BloC (Business Logic Component) design pattern using the power of reactive streams
https://pub.dev/packages/rx_bloc
62 stars 21 forks source link

Auth matrix refactoring #754

Closed StanevPrime closed 1 month ago

StanevPrime commented 2 months ago

Overview

Closes: #740

Auth matrix refactoring with the aim to achieve the following goals

Checklist

Implementation

Stability

Code quality

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.18%. Comparing base (6739d47) to head (d00d522).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #754 +/- ## =========================================== - Coverage 94.17% 92.18% -1.99% =========================================== Files 59 29 -30 Lines 1201 499 -702 =========================================== - Hits 1131 460 -671 + Misses 70 39 -31 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

GoranPrime commented 2 months ago

I've found 1 error and 2 hints upon a fresh project generation with the new auth_matrix module enabled.

  1. /lib_router/router.dart should have this import added to it:

import '../feature_auth_matrix/di/auth_matrix_page_with_dependencies.dart';

  1. The triple-slash documentation comments in the mentioned files should be replaced with just two slashes (or the library keyword added)
image
StanevPrime commented 2 months ago
  1. router.dart

The error should be fixed. Please retest.