search

Prime-arys / Speed-Pitch-changer-extension

Modify the speed with the pitch of a web video/audio.
MIT License
6 stars 1 forks source link

Pitch Change Semitones are not accurate #3

Closed Lesamuen closed 6 months ago

Lesamuen commented 9 months ago

One octave is 12 semitones. However, with the extension, 24 "semitones" are needed to reach one octave in either direction. Furthermore, when I want to transpose a music video by 6 semitones, to achieve the correct transpose I need to go +9 "semitones" or -14 "semitones", when the expected amount would be +12 and -12 if it were quartertones.

The speed change seems to work fine though; 6 clicks of speed change correctly equals 6 semitones of transpose, though I want to transpose correctly with speed being the same.

Lesamuen commented 9 months ago

After further testing: Extension semitones (in the positive direction) needed for correct semitone transpose

  1. 1
  2. 2
  3. 3
  4. 5
  5. 7
  6. 9
  7. 11
  8. 14
  9. 16
  10. 18
  11. 21
  12. 24
Prime-arys commented 9 months ago

I did some modifications to the library I use. Check a72f1ea870d2d27c082ed2da2dc8e2f9773bc616, this should solve the problem.

Lesamuen commented 7 months ago

Can you update it on the firefox store please? I can't figure out how to manually install this dev version.

Prime-arys commented 7 months ago

The new version 1.4.1 is out on mozilla addons store