search

PrimeDAO / prime-deals-dapp

DAO to DAO negotiations facilitated, ratified, and archived.
https://www.prime.xyz/deals
3 stars 1 forks source link

Feat/1060 swap execution etherscan link on deal dashboard #1090

Closed giladt closed 2 years ago

giladt commented 2 years ago

What was done

  1. Added firebase action to enable storing the swap transaction hash into the deal document.
  2. Added an Etherscan link to the voting section once a deal is in a claiming or completed state.

Testing

Tested manually both with FB emulator and the development environment.

Note!

Swaps executed prior to the time feature have been merged- won't show the link, as there's no record for the transaction hash in FS. It can be manually added to the document as swapTxHash: string.

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
prime-deals-dapp ✅ Ready (Inspect) Visit Preview Jun 30, 2022 at 2:03PM (UTC)
giladt commented 2 years ago
  • [x] imo, we should a fallback, when the link is not available -> checkback with prod

No fallback needed ATM. Confirmed with @blink-km.