Feature/1061 clause enhancements

[testing-life]

What was done

Testing

Before

After

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
prime-deals-dapp	✅ Ready (Inspect)	Visit Preview	Jul 27, 2022 at 8:32AM (UTC)

[hiaux0]

Overall, the UI integration looks clean! Thanks for picking the task up :) Was prob not straightforward to figure out the integration.

Happy coding (supportive message goes here) :sun_with_face:

---

Fnality

• [ ] Can the initial text area be more than 1 line? (4 or so, like the other text areas, cf. Stage 1)
• [ ] How easy is it to support resizing like other text areas?

---

Test text:

bold, italic, underline

• unoreder list
  • sub
    1. orede
    2. sub

copy paste

• from notion misses underline (note, pasting the notion text into github/gdoc also misses underline, so we might be okay?)

• from gdoc --> not working

• [ ] Find out if copy paste from other sources should be supported (because "people likely write up the terms somewhere else and just copy into the wizard cc @blink-km)

  • [ ] which ones?

[hiaux0]

Could you add into the initial comment

1. why ckeditor was chosen?
2. what format the formatted text is saved with?

[blink-km]

copy paste from other sources should be supported

[testing-life]

changes addressed:

• link formatting focus and icons styling
• paste in from gdocs
• initial input height
• input resizing

[testing-life]

why ckeditor was chosen? documentation, freshness of packages, ease of styling, available plugins. oh and i got it working the easiest :P

what format the formatted text is saved with? it's a string containing the text and formatted words wrapped in HTML elems (i,u,b, ul>li, etc)

[testing-life]

1. Probably best if you can use the palette colors from the design system for all elements rather than fixed HSL, hex etc. Please note that there are also variables for sizes, such as border-radius and padding that you can use.

   2. I get an error after trying to open a link I've entered. Maybe you can find a fix for that?

   3. Please make the hover-border change through the whole element and not only the lower half. If it requires a longer time to refactor, maybe it's better to triage it because it would probably come back to us during testing.

   4. Please revert the quotes in all files to double quotes... It appears to apply all .scss files.

   5. Please don't hate me for being picky! joy

ad1. fixed

ad2. resolved

ad3. fixed

ad4.fixed

ad5. that's ok, i am capable of hating people for several things simultaneously :P

[testing-life]

ad1. reinstated custom css. overriding some custom props from the component turned out impossible, plus i do think we should look into custom props grolbally, as per the telegram chat ad2. removed ad3. querySelector now uses index, so displays multiple editors.