PrimeDAO / prime-deals-dapp

DAO to DAO negotiations facilitated, ratified, and archived.
https://www.prime.xyz/deals
3 stars 1 forks source link

Dashboard: Switching privacy should change update the button and the status #1146

Open BartuCulha opened 2 years ago

BartuCulha commented 2 years ago
  1. Navigate here: https://prime-deals-dapp-jhff2ozmg-curvelabs.vercel.app/deal/5fVjBaQc36MxuMGqSzizTG
  2. Connect wallet: 0xBf3a5599f2f6CE89862d640a248e31F30B7ddF29 3: Click privacy toggle (make deal go from private to public)

Result: Status is public but the button says private. This happens only for this instance and not the other way around. Meaning: when you switch from public to private, status will update automatically to private.

Deal-dashboard-Prime-Deals (2).png

Expected: Dashboard to automatically update the changes correctly

IonelLupu commented 2 years ago

@BartuCulha Based on the UI design, the "Private deal" label shouldn't change when you change the privacy of a deal. Only the switcher should change, right?

If we write "Public deal", what should the switcher be then? Check or unchecked? If we write "Private deal", again, what should the switcher be then? Check or unchecked?

Let's say we write "Public deal" as a label and show the switcher as active/checked. If you click the switcher, it means you want to make it private. This means the label will say "Private deal" and the switcher will be deactivated. But this won't make any sense because the deal is Private but the switcher is deactivated. Does it mean the deal is NOT private? It will confuse the users.

Should we discuss this will Jaap as well?

BartuCulha commented 2 years ago

Hey! I was referring to the status under the Deal's Title. I think the label can stay the same.

Here the problem is that we have a private deal but the status says that the deal is public

Dashboard-Switching-privacy-should-change-update-the-button-and-the-status-·-Issue-1146-·-PrimeDAO-prime-deals-dapp

Dashboard-Switching-privacy-should-change-update-the-button-and-the-status-·-Issue-1146-·-PrimeDAO-prime-deals-dapp