search

PrimeDAO / prime-deals-dapp

DAO to DAO negotiations facilitated, ratified, and archived.
https://www.prime.xyz/deals
3 stars 1 forks source link

Cannot create a discussion for the 2nd clause #1155

Open BartuCulha opened 1 year ago

BartuCulha commented 1 year ago
  1. Navigate here:https://prime-deals-dapp-jhff2ozmg-curvelabs.vercel.app/deal/5fVjBaQc36MxuMGqSzizTG
  2. Connect wallet: 0xE834627cDE2dC8F55Fe4a26741D3e91527A8a498
  3. Try to create a discussion for the 2nd cluase

Result: Nothing will happen and console log will throw:

entry.223ea0a2b3cab3a3bf42.bundle.js:2 Uncaught (in promise) Error: FirebaseError: [code=invalid-argument]: Function setDoc() called with invalid data. Document fields must not be empty (found in field clauseDiscussions.`` in document deals-token-swap/5fVjBaQc36MxuMGqSzizTG) at U.addClauseDiscussion (entry.223ea0a2b3cab3a3bf42.bundle.js:2:3178561) at Tc.addClauseDiscussion (entry.223ea0a2b3cab3a3bf42.bundle.js:2:4606204) at Ps.addClauseDiscussion (entry.223ea0a2b3cab3a3bf42.bundle.js:2:4545336) at gu.createDiscussion (entry.223ea0a2b3cab3a3bf42.bundle.js:2:4696411) at async jh.addOrReadDiscussion (entry.223ea0a2b3cab3a3bf42.bundle.js:2:4761614)

hiaux0 commented 1 year ago

@BartuCulha FYI, a fix was introduced, but may still happen for already created clauses. For the clause you mentioned, it should be fixed.

When the console says sth about 

Document fields must not be empty (found in field clauseDiscussions.`` in document deals-token-swap/5fVjBaQc36MxuMGqSzizTG)

Would be nice if you can share the deal id (eg. 5fVjBaQc36MxuMGqSzizTG), because the deal clause is corrupted in the database.

image.png