Rename default firestore rules to testing rules - Githubissues

PrimeDAO / prime-deals-dapp

DAO to DAO negotiations facilitated, ratified, and archived.

https://www.prime.xyz/deals

3 stars 1 forks source link

Rename default firestore rules to testing rules #1162

Closed paweljanicki closed 1 year ago

paweljanicki commented 1 year ago

What was done

firebase.json renamed to firebase-testing.json That way the file is not automatically recognised by firebase CLI and therefore we avoid someone accidentally using the insecure "testing" rules for production
rename firestore.rules to firestore-testing.rules and specify to indicate that it contains rules not intended for production

Testing

verify that the commends work correctly for every environment

Before

firebase CLI by default was deploying with insecure firestore rules, unless explicitly pointing to production config file
After
firebase CLI requires to specify whether to use production or testing config (and therefore firestore rules). If not specified firebase CLI commends will fail

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
prime-deals-dapp	✅ Ready (Inspect)	Visit Preview	Aug 11, 2022 at 10:52AM (UTC)