search

PrimeDAO / prime-deals-dapp

DAO to DAO negotiations facilitated, ratified, and archived.
https://www.prime.xyz/deals
3 stars 1 forks source link

1154 - my deals bug #1169

Closed IonelLupu closed 1 year ago

IonelLupu commented 1 year ago

What was done

Fixed "my deals" button when you have "Partnered deals" tab selected.

First of all, I fixed a bug that showed up when you change the Metamask address. Aurelia, for some reason, cannot handle async router lifecycle hooks. The error was hard to debug but, at the end, I had to remove the async keyword from the attached lifecycle hook.

This fixed the issue, but in the mean time, I found that the "Open proposal" and "partnered deals" tabs were not displayed if the selected one didn't have any deals. So I fixed that as well. It now shows the other tab if the selected one doesn't have any deals

Testing

Before

After

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
prime-deals-dapp ✅ Ready (Inspect) Visit Preview Aug 17, 2022 at 11:26AM (UTC)
IonelLupu commented 1 year ago

Change request: Looks like you only are filtering for proposal lead? "a deal is “mine” if I am either the Proposal Lead or a Representative" (https://www.notion.so/primedao/All-Deals-My-Deals-7493545968cb4c0f965e2ec249716310#21393bab719144e5bfa1e5d41931d323)

  1. connect as 0xBf3a5599f2f6CE89862d640a248e31F30B7ddF29 2.1 refac/au2 branch -> shows also me as a rep 2.2 your branch -> only prop lead?

Good find. Fixed