PrimeDAO / prime-deals-dapp

DAO to DAO negotiations facilitated, ratified, and archived.
https://www.prime.xyz/deals
3 stars 1 forks source link

[Funding] after a deal was funded, then page refreshed, console error #1179

Open hiaux0 opened 1 year ago

hiaux0 commented 1 year ago

:warning: This may not always occur

Uncaught (in promise) TypeError: deal is undefined observeDealFundedInfo DealService.ts:286 _listeners index.js:381

image

IonelLupu commented 1 year ago

looks like this occurs when:

The underlying issue is that we are not waiting for the deals to load when we use moduleContract.on.

waitUntilTrue needs to be removed from Prime Deals. One solution is to use rxjs observables. (check the PR attached to this issue)