search

PrimeDAO / prime-deals-dapp

DAO to DAO negotiations facilitated, ratified, and archived.
https://www.prime.xyz/deals
3 stars 1 forks source link

[dashboard] Votes circle grey after deal was completed #1189

Open hiaux0 opened 1 year ago

hiaux0 commented 1 year ago

STEPS

  1. https://prime-deals-dapp-git-refac-deals-au2-staging-curvelabs.vercel.app/deal/tQToi3b58aRbU9aSArNi9P

image

Result

Expected

IonelLupu commented 1 year ago

@hiaux0 is this an old deal? Because old deals had this bug where votes were deleted?

hiaux0 commented 1 year ago

@hiaux0 is this an old deal? Because old deals had this bug where votes were deleted?

At least it was the latest deal in au2-staging. But good to know on the "votes were deleted" part

IonelLupu commented 1 year ago

I will try to see if it replicates on new deals

IonelLupu commented 1 year ago

@hiaux0 tested on AU2 staging and doesn't replicate. It seems the firebase functions were not deployed yet. We will get back to this issue after we merge AU2 into the development branch: image

After firebase functions are deployed again, this issue should be fixed

hiaux0 commented 1 year ago

functions were redeployed, and cannot be repro'd

IonelLupu commented 1 year ago

Yes. Retested now and everything is ok. Can proceed to QA