Added a few rxjs streams that can be used to wait for some other parts of the app to load. As described below, some part of the app was running without waiting for the deals list to load.
This approach (with rxjs operators) can be used to remove the waitUntilTrue hack we have in Prime Deals and also removing the "race conditions" spread across the app.
Testing
Before
looks like this occurs when:
you just started funding the deal. After aprox 5 min, this error goes away. This is because in the first 5 min, the contract data is taken from moduleContract.on. After 5 min, the contract data is take using moduleContract.queryFilter. The later makes the app not return any errors.
The underlying issue is that we are not waiting for the deals to load when we use moduleContract.on.
waitUntilTrue needs to be removed from Prime Deals. One solution is to use rxjs observables. (check the PR attached to this issue)
What was done
Added a few rxjs streams that can be used to wait for some other parts of the app to load. As described below, some part of the app was running without waiting for the deals list to load.
This approach (with rxjs operators) can be used to remove the
waitUntilTrue
hack we have in Prime Deals and also removing the "race conditions" spread across the app.Testing
Before
looks like this occurs when:
you just started funding the deal. After aprox 5 min, this error goes away. This is because in the first 5 min, the contract data is taken from moduleContract.on. After 5 min, the contract data is take using moduleContract.queryFilter. The later makes the app not return any errors. The underlying issue is that we are not waiting for the deals to load when we use moduleContract.on.
waitUntilTrue needs to be removed from Prime Deals. One solution is to use rxjs observables. (check the PR attached to this issue)
After