PrimeDAO / prime-deals-dapp

DAO to DAO negotiations facilitated, ratified, and archived.
https://www.prime.xyz/deals
3 stars 1 forks source link

1179 - fixed "after a deal is funded, on page refresh, an error occurs" #1199

Open IonelLupu opened 2 years ago

IonelLupu commented 2 years ago

What was done

Added a few rxjs streams that can be used to wait for some other parts of the app to load. As described below, some part of the app was running without waiting for the deals list to load.

This approach (with rxjs operators) can be used to remove the waitUntilTrue hack we have in Prime Deals and also removing the "race conditions" spread across the app.

Testing

Before

looks like this occurs when:

you just started funding the deal. After aprox 5 min, this error goes away. This is because in the first 5 min, the contract data is taken from moduleContract.on. After 5 min, the contract data is take using moduleContract.queryFilter. The later makes the app not return any errors. The underlying issue is that we are not waiting for the deals to load when we use moduleContract.on.

waitUntilTrue needs to be removed from Prime Deals. One solution is to use rxjs observables. (check the PR attached to this issue)

After

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
prime-deals-dapp ✅ Ready (Inspect) Visit Preview Aug 26, 2022 at 7:23AM (UTC)