search

PrimeDAO / prime-deals-dapp

DAO to DAO negotiations facilitated, ratified, and archived.
https://www.prime.xyz/deals
3 stars 1 forks source link

[TokenDetails] Wrong address shows token information sub form #414

Open hiaux0 opened 2 years ago

hiaux0 commented 2 years ago

Note: This is based on PR 401, because I tested on firefox, and 401 fixes a related firefox bug

  1. Token Details stage
  2. copy wallet address into Address field
  3. correctly show validation error
  4. switch to another stage, and come back
  5. Bug: see screenshot

image

BartuCulha commented 2 years ago

there's an another similar issue:

0x43D4A3cd90ddD2F8f4f693170C9c8098163502ad

Token Details stage copy this address: 0x43D4A3cd90ddD2F8f4f693170C9c8098163502ad Change the last letter from "d" to anything else switch to another stage, and come back Bug: see screenshot

Create-a-Partnered-Deal-Prime-Deals(1)

@hiaux0

curvelabs-dev commented 2 years ago

@hiaux0 I would add that it is not consistent with other pages that we would be seeing the red stuff in this specific case of returning to an invalid page from another page.

hiaux0 commented 2 years ago

@BartuCulha

Not reproducible on staging https://prime-deals-staging.vercel.app/initiate/token-swap/open-proposal/token-details (firefox and chromium)

Peek 2022-03-23 23-29

BartuCulha commented 2 years ago

I believe you have reproduced the issue. Mind the adress is invalid and you are able to see d2d token information

BartuCulha commented 2 years ago

Following these steps:

  1. Token Details stage
  2. copy wallet address into Address field
  3. correctly show validation error
  4. switch to another stage, and come back
  5. Bug: see screenshot

I have encountered a similar bug. This time the wallet address doesn't automatically show an error message, clicking save does not throw an error message as well

Create-a-Partnered-Deal-Prime-Deals (5)