[Discussions] Comment appears with no text

[hiaux0]

How this came up, mentioned here: https://github.com/PrimeDAO/prime-deals-dapp/issues/699#issuecomment-1103611163

STEPS:

1. Visit https://prime-deals-staging.vercel.app/deal/kHofvxovzrrKmqi5VZeN7A
2. Open discussions for "Rights? no thank you, the new dao can have them. V2"
3. 4th comment (or look for the one without text)

RESULT: No comment text

EXPECTED: Has comment text

---

Investigating a bit:

• That comment in question has isPrivate: "false", whereas the other have set it to "true".

• key decryption field in clauseDiscussions

  Indeed seems key related. I do get the key into the code, but seems the key is not what that comment needed. I remember now this was my doing, when deleting clauseDiscussions directly in Firebase. Convo still returns comments to the threadId, but a new key was generated when I created a "new" discussions

^ Continuing on the last sentence: But for this case, there are already other comments, that decrypt just fine

[renckorzay]

@hiaux0

Please describe in this structure:

STEPS: 1. 2. ...

RESULT: ... EXPECTED: ...

[hiaux0]

Fixed by 723.

Underlying issue was the same.

• same clauseId
• thus par deal and open prop had same discussion, BUT different decryption keys

[hiaux0]

Test prob was on a broken deal. Because underlying issue (same clauseIds) was fixed can be moved to Code Complete. But before moving to QA should clean up the existing broken deals on staging.

@dkent600

[BartuCulha]

Able to reproduce this here: https://prime-deals-staging.vercel.app/deal/kHofvxovzrrKmqi5VZeN7A

Steps to reproduce:

723