search

PrimeDAO / prime-deals-dapp

DAO to DAO negotiations facilitated, ratified, and archived.
https://www.prime.xyz/deals
3 stars 1 forks source link

Documentation: Videos should be embedded #962

Closed BartuCulha closed 2 years ago

BartuCulha commented 2 years ago
  1. Navigate here: https://prime-deals-staging.vercel.app/documentation/EditanExistingDeal

Result:

Video appears as a link Discuss-the-clauses-of-a-Deal-Documentation-Documentation-Prime-Deals.png

Expected:

If it's a video, it should be embedded just like in the homepage

dkent600 commented 2 years ago

@ogsamovar I don't think having embedded videos is going to be possible at this time. There are too many unaddressed issues and hurdles.

What I think you can do is obtain the necessary html for the video player (such as youtube) and embed that html yourself. Youtube, for example, makes it easy to generate such HTML.

ogsamovar commented 2 years ago

I managed to have videos (without youtube) by simply using the <video> tag:

<video controls autoplay width: 100% !important; height: auto !important;> <source src="https://ik.imagekit.io/primedao/PrimeDeals/1-connect-to-a-wallet__vbS8qu1O6.mp4" type="video/mp4"></video>

<video controls autoplay width: 100% !important; height: auto !important;>