953 - feat(discussions): add error when key of undefined - Githubissues

PrimeDAO / prime-deals-dapp

DAO to DAO negotiations facilitated, ratified, and archived.

https://www.prime.xyz/deals

3 stars 1 forks source link

953 - feat(discussions): add error when key of undefined #965

Closed hiaux0 closed 2 years ago

hiaux0 commented 2 years ago

What was done

throw when this.discussions[discussionId] is undefined
- because later is used for this.discussions[discussionId].key. The underlying ticket reported that error
- spent quite some time to trace how this can happen in the first place, and was just not able to reproduce
- thus, at least at error handling, so next time we will hopefully know better how to reproduce

:exclamation: I was not able to reproduce

STEPS

(after talking with Bartu, he mentioned, this was a newly created partnered deal from "Make an offer" wizard)
be disconnected (maybe you have to clear local storage, to be fully disconnected)
Navigate to partnered deal from 1.
toggle private Deal to true
create new comment

EXPECTED

I expected a bug as described in the ticket

RESULT

actually worked, and could not reproduce

Testing

Before

After

https://user-images.githubusercontent.com/30693990/167164621-4ba57872-e122-48eb-8afc-f3ed5c7fa4cc.mp4

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
prime-deals-dapp	✅ Ready (Inspect)	Visit Preview	May 6, 2022 at 3:31PM (UTC)