search

PrimeDAO / prime-deals-dapp

DAO to DAO negotiations facilitated, ratified, and archived.
https://www.prime.xyz/deals
3 stars 1 forks source link

Tests: Code instrumentation breaks aurelia-validation package #979

Open hiaux0 opened 2 years ago

hiaux0 commented 2 years ago

Discovered in PR 954

:warning: There is a bug when parsing code, that has coverage-helper-code. More specifically, aurelia-validation does not parse the helper code correctly https://github.com/aurelia/testing/issues/94. I found a fix, but would need to PR to the aurelia repo and stuff. (Maybe we just fork ourselves, will create a ticket) image

A fix I found is to update the parts of the regex

- $_\s\w\d\/\*.['"\]+;
+ $_\s\w\d\/\*.['"\]+();

Reported to package in question https://github.com/aurelia/validation/issues/571