search

PrimeDAO / prime-launch-dapp

https://launch.prime.xyz
6 stars 13 forks source link

Seed Reg: Please supply a valid image file type for project token logo #194

Open BartuCulha opened 3 years ago

BartuCulha commented 3 years ago

I am using these addresses for testing: 0x5592EC0cfb4dbc12D3aB100b257153436a1f0FEa DAI Seed token 0x80E1B5fF7dAdf3FeE78F60D69eF1058FD979ca64 PRIME

When the project token address is provided, I can see the logo but after clicking next I receive the following error. Please supply a valid image file type for project token logo

https://images.zenhubusercontent.com/352639756/430a148b-6ee6-4f53-8b36-e6b215771d3b/desktop_1631263877256.mp4

dkent600 commented 3 years ago

Clicking on the resulting link for 0x5592EC0cfb4dbc12D3aB100b257153436a1f0FEa one can see the image URL is "https://assets.coingecko.com/coins/images/9956/thumb/dai-multi-collateral-mcd.png?1574218774"

I think the problem is with the querystring.

Same with the other token.

BTW, we are using the phrase "Project Token" now, not "Seed Token"

BartuCulha commented 3 years ago

I am reopening this issue because it has occured again. Address used: 0xc778417E063141139Fce010982780140Aa0cD5Ab

Token Details _

dkent600 commented 3 years ago

I have removed the check for the image file extension. I think that since we are now displaying the image, and detecting whether it was possible to display it, there is no longer a need to check for the file extension.

The problem is that some people (like Koletivo) are supplying token urls that have no file extension (example: "https://gateway.pinata.cloud/ipfs/QmVChZZtAijsiTnMRFb6ziQLnRocXnBU2Lb3F67K2ZPHho").