search

PrimeDAO / prime-launch-dapp

https://launch.prime.xyz
6 stars 13 forks source link

remove hr from lbp stage4 #334

Open dkent600 opened 3 years ago

dkent600 commented 3 years ago

This HR (line) is not in the mocks and does not conform to the styling of the wizard forms. We should remove it.

image

giladt commented 3 years ago

I do see it in the mocks. I can fix the color though, otherwise the mocks should be updated.

image

@BartuCulha @dkent600

dkent600 commented 3 years ago

Which mock? I wonder if bartu added it.

BartuCulha commented 3 years ago

No, It's added by Jaap

dkent600 commented 3 years ago

OK, then I guess we have to do it. (But I swear in the mocks, I didn't see it). See here:

https://www.figma.com/file/yitVGz7k9h49eDmNsnys2Q/Prime-Launch-(final)?node-id=3655%3A13461

Is that figma no longer valid??? @BartuCulha

dkent600 commented 3 years ago

Maybe I should be using the source of truth doc, but I have to wonder where those screen shots are coming from.

dkent600 commented 3 years ago

@giladt be sure and get the vertical spacing (above and below the HR) right, according to the mock

BartuCulha commented 3 years ago

They are coming from this figma doc: https://www.figma.com/file/IIaSi96Paa9amdOUQ3NASZ/Prime-Launch-LBP-Developer-Handoff

This one is updated and I am able to change any mock on this document based on your feedback and suggestions.

BartuCulha commented 3 years ago

That being said, I totally agree with "This HR (line) is not in the mocks and does not conform to the styling of the wizard forms. We should remove it.".

I say we remove it, what do you think? @renc-curvelabs