search

PrimeDAO / prime-launch-dapp

https://launch.prime.xyz
6 stars 13 forks source link

688 - Time left display (fix and feature change) #698

Closed hiaux0 closed 2 years ago

hiaux0 commented 2 years ago

(quick introduction: Hello curious reader, I'll be joining Curvelabs officially on the 1st Jan 2022 as a Frontend Engineer)

What was done

a. fix #688 by adding largest to projectTokenInfo.html e6f6cd96558d1534b0f1732f766e643e102962c0 b. change how largest behaves a71d3df0885930202dae20b0209f01348d73de4e

Testing

http://localhost:3330/lbp/0x7c10deE4389feE638e2E84dC1671B25d7DF2935f (testing url)

  1. Navigate to /launches route
  2. select a type lpb

For a.

Before

Only showed hours image

After

Show hours and minutes (aka. the largest 2 image

For b.

Before

image

After

Only 2 largest image

/launches image

Responsiveness check

https://user-images.githubusercontent.com/30693990/146975648-9c63770f-f427-492e-bf04-8153e9447a25.mp4

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

prime-launch-dev – ./

🔍 Inspect: https://vercel.com/curvelabs/prime-launch-dev/BhcxpbpGtJTmjpT2umbFShKJS3pg
✅ Preview: https://prime-launch-dev-git-fix-688-time-left-largest-2-curvelabs.vercel.app

prime-launch-staging – ./

🔍 Inspect: https://vercel.com/curvelabs/prime-launch-staging/JA63Z4nEpxPYu5LwSBvGfMKbgWzU
✅ Preview: https://prime-launch-staging-git-fix-688-time-left-largest-2-curvelabs.vercel.app

hiaux0 commented 2 years ago

705