search

PrimeDAO / prime-launch-dapp

https://launch.prime.xyz
6 stars 13 forks source link

Update the Gnosis Safe URL #706

Open blink-km opened 2 years ago

blink-km commented 2 years ago

IMAGE 2565-01-19 06:49:10.jpg

At the pop-up before a user can submit an LBP launch, we have a link that is supposed to lead the user to Mainnet Gnosis Safe but it is currently linking the user to Rinkeby Gnosis Safe

blink-km commented 2 years ago

This is the updated URL: https://gnosis-safe.io/app/eth:0x52F50f557704938Df066EC4Db7426D66538E7796/

dkent600 commented 2 years ago

The FE is supplying the correct URL as far as I can tell:

https://gnosis-safe.io/app/#/safes/0x52F50f557704938Df066EC4Db7426D66538E7796/transactions

"0x52F50f557704938Df066EC4Db7426D66538E7796" is the SAFE contract address given us by the contracts-v2 ABI json file for mainnet. For some reason Safe thinks this is for rinkeby.

@Zitzak @codebuster22

Zitzak commented 2 years ago

Indeed, this is the safe on mainnet, address supplied by the ABIs. You can see the launch of the D2D token in its transactions. So this should just be the right URL

codebuster22 commented 2 years ago

If you see, this url (https://gnosis-safe.io/app/#/safes/0x52F50f557704938Df066EC4Db7426D66538E7796/transactions) resolves to a different URL (https://gnosis-safe.io/app/eth:0xc54Ad3e73BDE767738335809A5f20F9BB80Be8D3/balances).

Now they use same domain for different network.

https://gnosis-safe.io/app/{GnosisSpecificNetworkName}:{safeAddress}/

Where, GnosisSpecificNetworkName - A short name given to network by Gnosis. Eg. "eth" - for Ethereum mainnet, "rin" - Rinkeby Testnet

Now they use same domain for different network.

dkent600 commented 2 years ago

Where, GnosisSpecificNetworkName - A short name given to network by Gnosis. Eg. "eth" - for Ethereum mainnet, "rin" - Rinkeby Testnet

@codebuster22 Can you please point to documentation of this, where we can see the prefix values for each network?