search

PrimeDAO / prime-launch-dapp

https://launch.prime.xyz
6 stars 13 forks source link

Test: Update dependency name- sor2 -> sor #776

Closed giladt closed 1 year ago

giladt commented 1 year ago

Renamed the dependency in package.json from "@balancer-labs/sor2": "npm: @balancer-labs/sor^2.0.0-beta.9", -> "@balancer-labs/sor": "^2.0.0-beta.9".

This should solve the issue for Vercel is not building correctly.

Resolution

The old implementation used to work before, but on one of the failed builds I noticed this error:

image

At first, I tried to update the package to sor@4.0.1-beta.4, but without renaming it as above. That worked, and Vercel completed the build successfully. Introducing a new major version update might (/probably) bring breaking changes, so I've tried installing sor as the same version, just without renaming it.

Result

(pre-requried: engines: { node: ">=14.11.0 <15" }) Vercel build, run through successfully.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
prime-launch-dapp ✅ Ready (Inspect) Visit Preview Sep 7, 2022 at 0:03AM (UTC)
prime-launch-dapp-arbitrum ✅ Ready (Inspect) Visit Preview Sep 7, 2022 at 0:03AM (UTC)