search

PrinceJavier / causal_ccm

Package implementing Convergent Cross Mapping for causality inference in dynamical systems
MIT License
38 stars 9 forks source link

Are you calculating Y_hat or X_hat? #1

Closed lupupu closed 3 years ago

lupupu commented 3 years ago

https://github.com/PrinceJavier/causal_ccm/blob/d9c8be22f754258340d5177809e3fa938ed70020/causal_ccm/causal_ccm.py#L103

lupupu commented 3 years ago

The return is X_hat, and it is alway about X in the function of "predict".

PrinceJavier commented 3 years ago

Hi thanks for raising this. That should be X_hat. I've fixed the errors in the docstrings where X and Y were switched. Are they clearer now?

lupupu commented 3 years ago

Hi thanks for raising this. That should be X_hat. I've fixed the errors in the docstrings where X and Y were switched. Are they clearer now?

Thank you. It is clear now. It would be better if you could update the python package.

PrinceJavier commented 3 years ago

Hi I've updated the package. Closing this issue