search

PrincessRTFM / XIVComboPlugin

Plugin version of the icon replacement features in dalamud
GNU General Public License v3.0
31 stars 10 forks source link

Update for 7.1 compatability #115

Closed kbrighton closed 1 week ago

kbrighton commented 1 week ago

Here's a PR that will, hopefully, help with the 7.1 port. I've tested it on WAR and MCH, and I don't have any issues so far. There's one part that's commented out that looks to be debugging, and I couldn't find the new signature for what was being done there, so I figure it's something that can be fixed later.

Maxunit commented 1 week ago

I downloaded the latest github code real quick, applied the suggested changes (the debug stuff in ConfigWindow.cs included, or it errors out) and...i only tried it on Pictomancer and Machinist real quick, but the plugin seems to load fine and seems to work fine. I will stress-test it more later today after I had some sleep.

kbrighton commented 1 week ago

Responded to all the comments to the code. When I have a few minutes tomorrow I'll check the docs to find the right way to fix the debug. I'm also testing some changes to xivesp, so I might have a PR for you there too. I get the burn out! It's why I was hoping that this might be helpful. :)

Maxunit commented 1 week ago

the build.yml should probably be changed now as well, since Dalamud just went Stable.

kbrighton commented 1 week ago

Just made the change