search

PrincessRTFM / XIVComboPlugin

Plugin version of the icon replacement features in dalamud
GNU General Public License v3.0
31 stars 10 forks source link

Paladin Divine Might #83

Closed PetalTempest closed 1 year ago

PetalTempest commented 1 year ago

Hello! I was wondering if you would consider adding an option for Paladin to change Royal Authority into Holy Spirit, and Prominence into Holy Circle, when the Divine Might buff is active.

The priority would be lower than the Requiescat combo but higher than Atonement.

So for single target it would look something like: Requiescat combo > Holy Spirit (with Divine Might) > Atonement > Royal Authority combo

Then for AoE it would be: Requiescat combo > Holy Circle (with Divine Might) > Prominence combo.

Thank you for your consideration!

PrincessRTFM commented 1 year ago

In both cases, the existing normal combo chain is prioritised if it's already in progress; if you've done the first action then even if Divine Might is up it will continue the chain until it's finished. This is to save the chain (with the potency increase) because Divine Might lasts half a minute and HS/HC are both spells so they'll probably break the chain.

PetalTempest commented 1 year ago

Surprisingly enough it doesn't break the combo. Nothing does except switching from the Royal Authority combo to the Prominence combo; but if you still think it's best not to implement I understand. I appreciate the consideration.

PrincessRTFM commented 1 year ago

I don't play paladin; this was chosen purely on the basis of thinking it might break the chain and wanting to avoid that. I don't know which way is "best" to actually use. If any paladin mains come in and tell me that it should actually be the other way around, I can easily reorder the checks. If you find anything pointing at that, you can comment here and I'll change it.

PetalTempest commented 1 year ago

This is from The Balance. If you're not familiar, it's a website/discord that focuses on theorycrafting and optimizing rotations. In this graphic you can see Holy Spirit with Divine Might is the top priority filler. image As far as AoE there's nothing else to cast besides the Prominence combo, and you don't want to overwrite/waste the Divine Might buff so you just use Holy Circle after Prominence.

PrincessRTFM commented 1 year ago

Should be easy enough. If there's no reason to hold it until the combo ends, I'll just shift those two pieces up a little when I have the chance.

PetalTempest commented 1 year ago

Oh my gosh, I'm SO sorry. I thought your original reply meant you weren't going to implement the feature. Please forgive my misunderstanding. It works perfectly as is. Thank you sooooooo much!