search

Princesseuh / astro-social-images

Social image generator for Astro
53 stars 2 forks source link

When building social images are not saved to `dist` #8

Open HectorCastelli opened 1 year ago

HectorCastelli commented 1 year ago

I have a setup where I run npm run build then publish the dist directory to github pages.

I chose to ignore the public/social directory to avoid committing those images into my repository (as I don't really care about version controlling them and am happy to regenerate on every build).

When this happens, the images are generated in /public/socials, but not included in the dist directory. To circumvent this I am currently building twice on my CI.

Is this expected? And if so, is there a better workaround to this? Alternatively, is there a good reason to keep those social images committed in the repository?

HectorCastelli commented 1 year ago

Linking repository where this happens for reference: https://github.com/HectorCastelli/website

Princesseuh commented 1 year ago

This is unfortunately expected, Astro does not copy files generated during build to the dist folder.

This project is very old now and was created before proper integrations were added to Astro, so it doesn't use the proper way to do this in 2023

HectorCastelli commented 1 year ago

Is this repository open for contributions? If so I can try to submit a PR to patch this up.

Princesseuh commented 1 year ago

Is this repository open for contributions? If so I can try to submit a PR to patch this up.

Sure, I'll gladly review it once it's done 😄

HectorCastelli commented 1 year ago

Hey there @Princesseuh,

I've looked over the code and tried a couple of solutions but none of them really work out of the box quite well, except a hack of copying public/socials into dist as an integration step... I will take back my offer for that PR, my little hack is a crime against software engineering.

However, I've looked around for other alternatives and seems like https://github.com/delucis/astro-og-canvas is a good alternative to this repository. Does it make sense to link/endorse this alternative, so other users can avoid the time investment to jump thru the same hoops?

Princesseuh commented 1 year ago

Hey there @Princesseuh,

I've looked over the code and tried a couple of solutions but none of them really work out of the box quite well, except a hack of copying public/socials into dist as an integration step... I will take back my offer for that PR, my little hack is a crime against software engineering.

However, I've looked around for other alternatives and seems like https://github.com/delucis/astro-og-canvas is a good alternative to this repository. Does it make sense to link/endorse this alternative, so other users can avoid the time investment to jump thru the same hoops?

For sure, I trust Chris's package more than mine too at this point. I'll update the README and archive this repo tomorrow!