search

Princeton-CDH / bitKlavier

The piano, digitally reinvented.
http://bitklavier.com/
GNU General Public License v3.0
37 stars 5 forks source link

Synchronic "skip first" is actually skipping two #133

Closed dantrueman closed 5 years ago

dantrueman commented 5 years ago

make a sequence with, say, 4 transposition. when skip first is on, it will skip the first two, and when it is off, it will skip 1

mulshine commented 5 years ago

hmm unless im misunderstanding, this seems to work for me (at least for note-on first-note mode). perhaps this issue is mode-specific? do you experience the issue in all cases?

On Mon, Jun 10, 2019 at 12:44 PM dantrueman notifications@github.com wrote:

make a sequence with, say, 4 transposition. when skip first is on, it will skip the first two, and when it is off, it will skip 1

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Princeton-CDH/bitKlavier/issues/133?email_source=notifications&email_token=ABUVDAHYHUGSZMKAVSEA47TPZ2AIBA5CNFSM4HWVE63KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GYTPVOA, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUVDADIARJ3VKCXQTHC7RTPZ2AIBANCNFSM4HWVE63A .

dantrueman commented 5 years ago

right, ok, yes it is working, but the display is off, always ahead by one in the multisliders. for all modes

From: Mike Mulshine notifications@github.com Sent: Monday, June 10, 2019 3:06 PM To: Princeton-CDH/bitKlavier Cc: Daniel L. Trueman; Author Subject: Re: [Princeton-CDH/bitKlavier] Synchronic "skip first" is actually skipping two (#133)

hmm unless im misunderstanding, this seems to work for me (at least for note-on first-note mode). perhaps this issue is mode-specific? do you experience the issue in all cases?

On Mon, Jun 10, 2019 at 12:44 PM dantrueman notifications@github.com wrote:

make a sequence with, say, 4 transposition. when skip first is on, it will skip the first two, and when it is off, it will skip 1

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Princeton-CDH/bitKlavier/issues/133?email_source=notifications&email_token=ABUVDAHYHUGSZMKAVSEA47TPZ2AIBA5CNFSM4HWVE63KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GYTPVOA, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUVDADIARJ3VKCXQTHC7RTPZ2AIBANCNFSM4HWVE63A .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Princeton-CDH/bitKlavier/issues/133?email_source=notifications&email_token=ACVGNNQFNRT6DAW5SA3RWH3PZ2Q37A5CNFSM4HWVE63KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXK4TWQ#issuecomment-500550106, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACVGNNQKT5GI2R3CNY72IG3PZ2Q37ANCNFSM4HWVE63A.