search

Princeton-CDH / bitKlavier

The piano, digitally reinvented.
http://bitklavier.com/
GNU General Public License v3.0
37 stars 5 forks source link

Reset does not update UI while preparation view is open #57

Closed mulshine closed 6 years ago

mulshine commented 7 years ago

Platform/OS

10.12.2

bitKlavier version number

0.0.1.b1

Format and (if applicable) host

standalone

Expected Behavior

Reset should update UI when preparation view is open

Actual Behavior

No change in UI when Reset is performed

Steps to Reproduce Behavior

Create a modification and reset on a prep, open the prep view, enact the modification (UI changes), enact the reset (UI does not change)

mulshine commented 7 years ago

Really? seriously thought I solved this!

On Fri, Oct 20, 2017 at 8:53 AM, dantrueman notifications@github.com wrote:

Reopened #57 https://github.com/Princeton-CDH/bitKlavier/issues/57.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Princeton-CDH/bitKlavier/issues/57#event-1302945072, or mute the thread https://github.com/notifications/unsubscribe-auth/AGlRgPxj8FGiOZ6LGlkfpLBp8IDowiOSks5suJfjgaJpZM4O5YXR .

dantrueman commented 7 years ago

oh, maybe you did, but it was still open and i accidentally closed it, and then reopened it.

On Oct 20, 2017, at 10:16 AM, Mike Mulshine notifications@github.com<mailto:notifications@github.com> wrote:

Really? seriously thought I solved this!

On Fri, Oct 20, 2017 at 8:53 AM, dantrueman notifications@github.com<mailto:notifications@github.com> wrote:

Reopened #57 https://github.com/Princeton-CDH/bitKlavier/issues/57.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Princeton-CDH/bitKlavier/issues/57#event-1302945072, or mute the thread https://github.com/notifications/unsubscribe-auth/AGlRgPxj8FGiOZ6LGlkfpLBp8IDowiOSks5suJfjgaJpZM4O5YXR .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/Princeton-CDH/bitKlavier/issues/57#issuecomment-338219447, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKpmtnOtlvv0-OCJYaeBlUnKRuNDvJzeks5suKtGgaJpZM4O5YXR.

dantrueman commented 7 years ago

if it’s fixed, can you close it and also add that to the “release 2” draft… ?

;—}

On Oct 20, 2017, at 10:16 AM, Mike Mulshine notifications@github.com<mailto:notifications@github.com> wrote:

Really? seriously thought I solved this!

On Fri, Oct 20, 2017 at 8:53 AM, dantrueman notifications@github.com<mailto:notifications@github.com> wrote:

Reopened #57 https://github.com/Princeton-CDH/bitKlavier/issues/57.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Princeton-CDH/bitKlavier/issues/57#event-1302945072, or mute the thread https://github.com/notifications/unsubscribe-auth/AGlRgPxj8FGiOZ6LGlkfpLBp8IDowiOSks5suJfjgaJpZM4O5YXR .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/Princeton-CDH/bitKlavier/issues/57#issuecomment-338219447, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKpmtnOtlvv0-OCJYaeBlUnKRuNDvJzeks5suKtGgaJpZM4O5YXR.