Princeton-CDH / bitKlavier

The piano, digitally reinvented.
http://bitklavier.com/
GNU General Public License v3.0
37 stars 5 forks source link

Nostalgic Undertow bug #65

Closed dantrueman closed 7 years ago

dantrueman commented 7 years ago

When undertow value is high and you play high notes, we got loud pops at the ends of the undertow notes; something is wrong with the way notes are shut off if the sample is too short to cover the entire undertow val.

to reproduce: use Nostalgic example 3, set undertow value really high, say 6000, and then play high notes on the piano

mulshine commented 7 years ago

@dantrueman I have noticed this as well. This maybe be when undertow is longer than the sample itself?