Princeton-CDH / derrida-django

Derrida's Margins - Python/Django web application
https://derridas-margins.princeton.edu
Apache License 2.0
8 stars 1 forks source link

Visualization issues #206

Closed thatbudakguy closed 6 years ago

thatbudakguy commented 6 years ago

notes from the meeting:

rlskoeser commented 6 years ago

Also doesn't work on touch devices. Maybe we can make click/tap perform the same action as current hover.

@xinyil how do you feel about making the dots larger? It seems like a small target for touch.

xinyil commented 6 years ago

@rlskoeser I think it's a question of which do we care more: individual record access or the overall visual comparison of the numbers of dots

meg-codes commented 6 years ago

Updated this to:

rlskoeser commented 6 years ago

@bwhicks could we also add an aria-only total of references for each section? As a counterpart to the visual indicator/histogram functionality.

meg-codes commented 6 years ago

@rlskoeser I don't see why not. I'll add that to the list.

meg-codes commented 6 years ago

I've got a working solution for this (used JS because for chapter divisions, the template iterates over each reference and determines whether to print it for each), but this side steps that by dynamically setting aria-label based on the number of marker nodes.

rlskoeser commented 6 years ago

@bwhicks this is so much better than it was. A few small issues, wondering if we can easily fix.