Princeton-CDH / derrida-django

Derrida's Margins - Python/Django web application
https://derridas-margins.princeton.edu
Apache License 2.0
8 stars 1 forks source link

Feature/a11y navigation #209

Closed thatbudakguy closed 6 years ago

thatbudakguy commented 6 years ago

refs #205

codecov-io commented 6 years ago

Codecov Report

Merging #209 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #209   +/-   ##
=======================================
  Coverage     95.6%   95.6%           
=======================================
  Files           89      89           
  Lines         4371    4371           
=======================================
  Hits          4179    4179           
  Misses         192     192

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 45e4e71...bb22684. Read the comment docs.

meg-codes commented 6 years ago

This looks good to me from a screen reader stand point (at least, the link works!). 'Skip to navigation' does appear on focus when tab navigating regardless of screen reader, but only when tab navigating, which I believe is the point.