Princeton-CDH / derrida-django

Derrida's Margins - Python/Django web application
https://derridas-margins.princeton.edu
Apache License 2.0
8 stars 1 forks source link

Book data export does not include all titles in the reference data export #246

Closed rlskoeser closed 3 years ago

kmcelwee commented 3 years ago

List of IDs that are in reference data but not in instance data export:

https://derridas-margins.princeton.edu/titles/208/
https://derridas-margins.princeton.edu/titles/238/
https://derridas-margins.princeton.edu/titles/33/
https://derridas-margins.princeton.edu/titles/132/
https://derridas-margins.princeton.edu/titles/237/
https://derridas-margins.princeton.edu/titles/236/
https://derridas-margins.princeton.edu/titles/60/
https://derridas-margins.princeton.edu/titles/229/
https://derridas-margins.princeton.edu/titles/111/
https://derridas-margins.princeton.edu/titles/3/
https://derridas-margins.princeton.edu/titles/203/
https://derridas-margins.princeton.edu/titles/214/
https://derridas-margins.princeton.edu/titles/103/
kmcelwee commented 3 years ago

something like cited_in__isnull=False or reference__isnull=False

kmcelwee commented 3 years ago

The exact IDs listed above were added to the export as a consequence of b9af415

rlskoeser commented 3 years ago

Confirmed fixed in the new exports!

Loaded the reference & book/instance csv files with pandas, generated a unique list of book ids from each, and confirmed that the set of book ids from the reference dataset is a subset of the full list of book ids.