Princeton-CDH / derrida-django

Derrida's Margins - Python/Django web application

https://derridas-margins.princeton.edu

Apache License 2.0

8 stars 1 forks source link

Add ink and IIIF links to intervention export #266

Closed kmcelwee closed 3 years ago

kmcelwee commented 3 years ago

[x] Rename file to annotation ~- [ ] drop intervention type column~ This did not exist (?)

codecov-commenter commented 3 years ago

Codecov Report

Merging #266 (49244c4) into develop (6c90527) will decrease coverage by 0.12%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #266      +/-   ##
===========================================
- Coverage    96.15%   96.02%   -0.13%     
===========================================
  Files           98       98              
  Lines         5148     5362     +214     
===========================================
+ Hits          4950     5149     +199     
- Misses         198      213      +15

rlskoeser commented 3 years ago

Forgot to say — I don't want the data files committed to the repo! Were they added by accident? Please remove and add to gitignore

kmcelwee commented 3 years ago

@rlskoeser Your suggestions look a lot cleaner than the regex / string concatenation, thank you! I thought you had said we wanted the dataset in the github repo, I got the complete opposite message. I've removed that data and added those files to the gitignore. If you give me the green light, I'm happy to merge and deploy!

rlskoeser commented 3 years ago

I thought you had said we wanted the dataset in the github repo, I got the complete opposite message. I've removed that data and added those files to the gitignore.

Sorry for the miscommunication! I wondered about that. I want the datapackage files in the repo, and it makes sense to have a standard path where the data exports will put the files by default and where the datapackage validation can reference them — but I don't actually want the data stored in the repo and versioned with the code.