Princeton-CDH / derrida-django

Derrida's Margins - Python/Django web application
https://derridas-margins.princeton.edu
Apache License 2.0
8 stars 1 forks source link

238 update reference data export #271

Closed kmcelwee closed 3 years ago

kmcelwee commented 3 years ago

New export is attached: reference_data.zip

rlskoeser commented 3 years ago
  • I hard-coded get_section() because "Part 1" and "Part 2" doesn't have page number information (?!)

Yeah, there was something weird/dumb about the way we did that because we added it late and were trying to keep it super simple (i.e. not introducing multiple models or unnecessary hierarchy). I think we only ever used it for the histogram viz, so it didn't matter that much. (This may be part of the reason we didn't include it in the exports the first time).

  • There are 4 references without chapter information because they occur before the first chapter (?)

yeah, I see it. weird, but could be plausible; inclined not to worry about this and trust the data as it is in the system