Princeton-CDH / derrida-django

Derrida's Margins - Python/Django web application

https://derridas-margins.princeton.edu

Apache License 2.0

8 stars 1 forks source link

Stub data package and add frictionless to requirements #279

Closed kmcelwee closed 2 years ago

kmcelwee commented 3 years ago

Conversation being tracked on #277

codecov-commenter commented 3 years ago

Codecov Report

Merging #279 (2cc7b10) into develop (c294cdd) will increase coverage by 0.18%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #279      +/-   ##
===========================================
+ Coverage    96.11%   96.29%   +0.18%     
===========================================
  Files           99       99              
  Lines         5249     5775     +526     
===========================================
+ Hits          5045     5561     +516     
- Misses         204      214      +10

rlskoeser commented 2 years ago

@kmcelwee I tried to pip install this update with frictionless data and it doesn't work with python 3.5. You'd better take it out of the requirements (since we don't need it in production) and just add it installation to the instructions for validating the datasets (and note that it won't work on python 3.5!)