Princeton-CDH / derrida-django

Derrida's Margins - Python/Django web application

https://derridas-margins.princeton.edu

Apache License 2.0

8 stars 1 forks source link

Revise proxy iiif info.json handling for more cases #280

Closed rlskoeser closed 3 years ago

rlskoeser commented 3 years ago

It turns out I already had code for this, it just wasn't being applied in all the cases where it was needed.

While I was at it, I added an OrderedDict for the response json so that we preserve the original order of the output when we modify the id.

codecov-commenter commented 3 years ago

Codecov Report

Merging #280 (a63c363) into develop (6c90527) will increase coverage by 0.00%. The diff coverage is 25.00%.

@@           Coverage Diff            @@
##           develop     #280   +/-   ##
========================================
  Coverage    96.15%   96.15%           
========================================
  Files           98       98           
  Lines         5148     5149    +1     
========================================
+ Hits          4950     4951    +1     
  Misses         198      198

rlskoeser commented 3 years ago

good catch on the case I missed! thank you