Princeton-CDH / derrida-django

Derrida's Margins - Python/Django web application

https://derridas-margins.princeton.edu

Apache License 2.0

8 stars 1 forks source link

insertion data export revisions #282

Closed rlskoeser closed 3 years ago

rlskoeser commented 3 years ago

added a deploy note about importing updated manifests to get corrected page labels from figgy
order canvases by item and label so that insertions within a work will group together

questions:

All book type values are book because only books can have insertions. Drop the field and note in the dataset readme?
the id field doesn't really look like an id to me; what if we call it label? (do we need an id?)

codecov-commenter commented 3 years ago

Codecov Report

Merging #282 (bdcc067) into develop (abc7523) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #282   +/-   ##
========================================
  Coverage    96.08%   96.08%           
========================================
  Files           99       99           
  Lines         5290     5290           
========================================
  Hits          5083     5083           
  Misses         207      207

rlskoeser commented 3 years ago

I was just eyeballing the column and missed the journal article. I'll leave it.

Agree an id would be useful, will figure out something I can use.

kmcelwee commented 3 years ago

Wait! we need to exclude pk 243.