Princeton-CDH / geniza

version 4.x of the Princeton Geniza Project
https://geniza.princeton.edu
Apache License 2.0
11 stars 2 forks source link

Polygon annotation box requires hard refresh to start working (does not work immediately) #1513

Closed kseniaryzhova closed 9 months ago

kseniaryzhova commented 10 months ago

testing notes (QA)

On the QA site, open or create a transcription or translation. After a hard refresh:


Describe the bug When the polygon annotation box icon is selected in the TE, it does not immediately start to draw the lines. You have to do a hard refresh and then it will allow you to draw the polygon.

To reproduce Steps to reproduce the behavior:

  1. Go to the transcription editor of any document.
  2. Click "create new transcription (or translation)"
  3. Click on polygon annotation icon.
  4. Shift and click on the image.
  5. See error.
  6. Hard refresh
  7. Try steps 3-4 again.

Expected behavior I want to be able to draw a polygon annotation box as soon as the icon is selected, without the need for a refresh.

Screenshots Marina's screencapture documenting the issue

Device information

blms commented 10 months ago

I'm not able to replicate this one consistently in Chrome (120.0.6099.109) or Safari (16.6) on Mac (13.5.2) using my touchpad.

Could it be that you are "shift-clicking" once before "shift-dragging"? It sometimes behaves a bit strangely when I "shift-click" first, though it ultimately does start drawing after a couple tries.

Here's when I try Shift+Click on the canvas first, then Shift+Drag:

https://github.com/Princeton-CDH/geniza/assets/7234006/c306983d-6209-4251-ad77-7005c6ecc6b0

And here's when I just Shift+Drag right away after clicking the icon:

https://github.com/Princeton-CDH/geniza/assets/7234006/d1d14ca6-a7d0-452d-a7d9-da0a88edae1d

The latter seems to work consistently. Is that your experience as well? (In any case, I'm fairly sure this is an issue in the Annotorious library rather than in Geniza!)

blms commented 9 months ago

Got a pull request out to Annotorious for this: https://github.com/annotorious/annotorious-openseadragon/pull/190

It was a known bug in Annotorious-OpenSeadragon. Hopefully this will fix it! Marking as blocked until that PR is reviewed since I expect it will need additional work.

kseniaryzhova commented 9 months ago

@blms works well, thank you! Closing!