Princeton-CDH / geniza

version 4.x of the Princeton Geniza Project
https://geniza.princeton.edu
Apache License 2.0
11 stars 2 forks source link

Allow ingest and editing of line-level annotations (#1504) #1537

Closed blms closed 6 months ago

blms commented 7 months ago

In this PR

Per #1504:

see also https://github.com/Princeton-CDH/annotorious-tahqiq/pull/31

Notes and questions

codecov[bot] commented 7 months ago

Codecov Report

Merging #1537 (0434bdd) into develop (a18ae8b) will increase coverage by 0.20%. Report is 52 commits behind head on develop. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1537 +/- ## =========================================== + Coverage 98.43% 98.64% +0.20% =========================================== Files 219 227 +8 Lines 12329 14217 +1888 =========================================== + Hits 12136 14024 +1888 Misses 193 193 ```
blms commented 6 months ago

Good call @rlskoeser, the exports work fine as they just call the same methods content_html and content_text that we use in the public site. However, the filenames were showing up as unknown-author, so I went ahead and fixed that and added a test for it. Merging as soon as checks pass—thanks for the review!