Closed blms closed 6 months ago
Merging #1537 (0434bdd) into develop (a18ae8b) will increase coverage by
0.20%
. Report is 52 commits behind head on develop. The diff coverage is100.00%
.
Good call @rlskoeser, the exports work fine as they just call the same methods content_html
and content_text
that we use in the public site. However, the filenames were showing up as unknown-author
, so I went ahead and fixed that and added a test for it. Merging as soon as checks pass—thanks for the review!
In this PR
Per #1504:
textGranularity
property to indicate block- or line-level annotation granularity, and a new foreign-key relation between Annotations to represent relationships between the twosee also https://github.com/Princeton-CDH/annotorious-tahqiq/pull/31
Notes and questions
partOf
a good field name for the associated block's ID in a line-level annotation? It’s not standard W3C, as that field name typically refers to an AnnotationCollection that an AnnotationPage is part of, but not sure how else to indicate in the serializer what the associated block should be for a line.textGranularity
could remain null for normal (block-level) annotations, to avoid having to update code everywhere annotations are created/parsed/etc. Also avoids having to write a data migration to add block granularity to all existing annotations.