Princeton-CDH / geniza

version 4.x of the Princeton Geniza Project
https://geniza.princeton.edu
Apache License 2.0
11 stars 2 forks source link

Migrate regex from python to solr (#1286) #1555

Closed blms closed 6 months ago

blms commented 6 months ago

As you suggested @rlskoeser, moving the regex to solr was absolutely the way to go here! Not only did it simplify the indexing code and reduce the index size, but it also fixed a bug where a search term without sigla would not be highlighted in a transcription where that term only appears with sigla.

codecov[bot] commented 6 months ago

Codecov Report

Merging #1555 (f49a3ad) into develop (fc2b7a2) will increase coverage by 0.00%. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1555 +/- ## ======================================== Coverage 98.46% 98.46% ======================================== Files 226 226 Lines 12618 12622 +4 ======================================== + Hits 12424 12428 +4 Misses 194 194 ```